Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend): migrate to TypeScript and Vite #6534

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

chore(frontend): migrate to TypeScript and Vite #6534

wants to merge 23 commits into from

Conversation

JoltCode
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • 📝 Documentation
  • 🧑‍💻 Refactor
  • 🤖 Build or CI

Related Issue

Fixes #6533
Fixed #6531

Describe this PR

A brief description of how this solves the issue.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend labels Aug 20, 2024
JoltCode and others added 20 commits August 20, 2024 23:03
@JoltCode
chore(frontend/redux): migrate rest of reducers to TypeScript
34f63c6
@JoltCode
chore(frontend/utils): migrate safe_storage to TypeScript
e1287d5
@JoltCode
chore(frontend): loads more migration of files to ts
76bc48f
@JoltCode
Merge branch 'hotosm:develop' into typescript-vite
5053181
@JoltCode
fix,chore(frontend/redux): fix reducers combined return type
a9f6636
@JoltCode
chore(frontend): migrate footer to TS
0a5a7cd
@JoltCode
chore(frontend): more ts migrations
454d43c
@JoltCode
chore(frontned): more TS migrations :D
67a4f7b
@JoltCode
chore(frontend): more TS Migrations!
463f7b5
@JoltCode
chore(frontend): hooks and utils migrations to TS
e64e9ab
@JoltCode
chore(frontend): mostly comments and contributions TS migrations
e1d2b2b
@JoltCode
chore(frontend): migrate components and utils to TS
f4cd684
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bf8cfec 
for more information, see https://pre-commit.ci
@JoltCode
chore(frontend): more migrations to TS
462993e
@JoltCode
chore(frontend): TS Migrations, allow JS in tsconfig
0060e30
@JoltCode
chore(frontend): migrate loads of svg icons to TS, fix vite config
8fe300f
@JoltCode
chore(frontend): migrate more svg icons to TS
1d9811e
@JoltCode
chore(frontend): migrate more svgIcons to TS
1f1a417
@JoltCode
chore(frontend/svgIcons): migrate final svgIcons to TS and functional…
20f7aaf 
… components!!!!
@JoltCode
chore(frontend): lots of TS Migrations - base site now rendering - al…
dad2a63 
…though with errors
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@htulipe htulipe mentioned this pull request Oct 24, 2024
Open
@royallsilwallz
Copy link
Contributor

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete?
cc - @htulipe @ramyaragupathy @manjitapandey

@JoltCode
Copy link
Collaborator Author

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

Feel free to shoot me a DM on Slack as well! 😄

@royallsilwallz
Copy link
Contributor

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

@JoltCode
Copy link
Collaborator Author

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

Yeah it is a pretty hefty task! Sure, I'd be more than happy to call and discuss! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from JavaScript --> TypeScript Replace craco / webpack frontend module bundler with vite
2 participants
@JoltCode @royallsilwallz