Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] More filters menu height should extend to the bottom of the page or container should not overflow #5884

Closed
HelNershingThapa opened this issue Jun 6, 2023 · 5 comments · Fixed by #6325

Comments

@HelNershingThapa
Copy link
Contributor

Describe the bug
The current implementation of the more filters menu in our web application is causing visual inconsistencies and usability issues. The menu's height does not extend to the bottom of the page, resulting in an awkward appearance and an overall poor user experience.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the Explore Projects page with the More Filters functionality.
  2. Expand the filters menu.
  3. Observe that the menu's height does not extend to the bottom of the page or that the container overflows, causing scrolling on the main page.

Expected behavior
The height of the filters menu should be adjusted to fill the entire vertical space from the top of the page to the bottom. Alternatively, we can modify the container to prevent overflowing the page, enabling scrolling within the filters menu while keeping the rest of the page static.

Screenshots
image
screencapture-tasks-stage-hotosm-org-explore-filters-2023-06-06-13_52_51

Additional context
This issue was brought up by @kshitijrajsharma on our Slack channel

@mtalhabaig3
Copy link
Contributor

@HelNershingThapa can I go ahead with this?

@HelNershingThapa
Copy link
Contributor Author

@mtalhabaig3 Yeah, sure, you can. Feel free to ask if you need anything.

@mtalhabaig3
Copy link
Contributor

Alright!

@HelNershingThapa
Copy link
Contributor Author

@mtalhabaig3 It has been a while. If there have been any updates on the development, please let me know.

@mtalhabaig3
Copy link
Contributor

mtalhabaig3 commented Jun 21, 2023

@HelNershingThapa I started working on it but eventually got busy with some interviews and assessments, got done with it yesterday. Sorry about not being in contact. I am resuming the work on it and will let you know with the updates! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment