You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi! i've been using this crate for a while for the kornia-rs repository and recently we benchmarked against different existing libraries and we found that the implementation of the decompress function is quite slow compared to the one in tensorflow.
Digging a bit into it, i found that mainly this crate uses the raw::tj3Decompress8 that encapsulates all the logic in there, while in the tensorflow version seems a bit more sophisticated and the time results seems quite considerable to review the current implementation.
Happy to assist with anything.
The text was updated successfully, but these errors were encountered:
Hi, the TurboJPEG API used by this crate is a relatively thin wrapper around the libjpeg API, so it should not, by itself, cause degraded performance. It certainly should not make decompression 4x slower!
In the benchmark results that you refer to, the test image is very small and the reported times are in 10s of microseconds, which is so low that the benchmark might be strongly influenced by other factors besides raw decoding speed. For example, one way to make the comparison a bit more fair is to remove the file I/O from the equation by decoding from bytes that are already loaded into memory.
hi! i've been using this crate for a while for the
kornia-rs
repository and recently we benchmarked against different existing libraries and we found that the implementation of the decompress function is quite slow compared to the one in tensorflow.You can check here some numbers: kornia/kornia-rs#58
Digging a bit into it, i found that mainly this crate uses the
raw::tj3Decompress8
that encapsulates all the logic in there, while in the tensorflow version seems a bit more sophisticated and the time results seems quite considerable to review the current implementation.Happy to assist with anything.
The text was updated successfully, but these errors were encountered: