feat: Add support for redaction and regex patterns #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
documentation
| @@ -54,7 +54,7 @@ module "s3_processor" { | |||
| } | |||
|
|
|||
|
|
|||
| environment_variables = { | |||
| environment_variables = merge({ | |||
There was a problem hiding this comment.
Which set of variables wins, first or second?
There was a problem hiding this comment.
According to the Terraform docs the second set wins. I don't have a strong opinion on which order is better and would happily move the extra_env_vars first to avoid accidental/intentional overrides.
If more than one given map or object defines the same key or attribute, then the one that is later in the argument sequence takes precedence.
|
It looks like the other PR was closed due to inactivity and some open questions. We'll close this PR in 2 weeks if we don't hear back on an update to either PR. |
|
Closing for now, please re-open if you find more time to review the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
regex_patternvariableextra_env_varsvariable to allow additional environment variables to be set on the lambdaHow to verify that this has the expected result