Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json is missing dependency: shimmer #149

Closed
tayles opened this issue May 13, 2024 · 0 comments · Fixed by #150
Closed

package.json is missing dependency: shimmer #149

tayles opened this issue May 13, 2024 · 0 comments · Fixed by #150
Labels
type: bug Something isn't working

Comments

@tayles
Copy link
Contributor

tayles commented May 13, 2024

The file src/web-vitals-autoinstrumentation.ts#L39 includes an import of shimmer, but this is not defined as a dependency in package.json.

I believe this was introduced in v0.2.1 in #140.

Versions

0.2.1

Steps to reproduce

  1. Run depcheck to detect unused/missing dependencies:
> npx depcheck

Unused devDependencies
* @types/jest
* jest
* jest-environment-jsdom
* prettier
* typescript
Missing dependencies
* shimmer: ./src/web-vitals-autoinstrumentation.ts

Additional context

This is reported by our build system (using esbuild + pnpm):

✘ [ERROR] Could not resolve "shimmer"

    node_modules/.aspect_rules_js/@[email protected]/node_modules/@honeycombio/opentelemetry-web/dist/src/web-vitals-autoinstrumentation.js:41:37:
      41 │ const shimmer = __importStar(require("shimmer"));
         ╵                                      ~~~~~~~~~
@tayles tayles added the type: bug Something isn't working label May 13, 2024
@tayles tayles mentioned this issue May 13, 2024
Merged
MustafaHaddara pushed a commit that referenced this issue May 15, 2024
@tayles
fix: Add missing dependency shimmer to package.json (#150)
2dc1eb9 
<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

Solves #149

## Which problem is this PR solving?

- Closes #149

## Short description of the changes

#140 added a dependency on
[shimmer](https://www.npmjs.com/package/shimmer) in
[src/web-vitals-autoinstrumentation.ts#L39](https://github.com/honeycombio/honeycomb-opentelemetry-web/blob/main/src/web-vitals-autoinstrumentation.ts#L39),
but this is not defined in `package.json`. This change adds an explicit
dependency for this.

## How to verify that this has the expected result

Run `npx depcheck` to verify that all dependencies in the code are
referenced in `package.json`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add missing dependency shimmer to package.json tayles/honeycomb-opentelemetry-web
1 participant
@tayles