package.json lists dev-only dependencies in dependencies
#142
Labels
type: bug
Something isn't working
Comments
3 tasks
MustafaHaddara
added a commit
that referenced
this issue
May 9, 2024
## Which problem is this PR solving? - Closes #142 ## Short description of the changes Moves dev-only dependencies into `devDependencies` ## How to verify that this has the expected result - [x] tests pass - [x] the build succeeds - [x] use `npm link` or `yalc` to test this version in an application and confirm that traces are still being sent Also, I specifically checked for the presence of these transitive dependencies in an app that used this library. Before this code change: ``` $ npm ls @typescript-eslint/eslint-plugin [email protected] ├─┬ @honeycombio/[email protected] │ └── @typescript-eslint/[email protected] ├── @typescript-eslint/[email protected] └─┬ [email protected] └── @typescript-eslint/[email protected] deduped ``` after: ``` $ npm ls @typescript-eslint/eslint-plugin [email protected] ├── @typescript-eslint/[email protected] └─┬ [email protected] └── @typescript-eslint/[email protected] deduped ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
are all listed as dependencies, rather than devDependencies.
This causes problems when those libraries have stricter requirements (ie.
@typescript-eslint/[email protected]requires a higher version of Node than we require)The text was updated successfully, but these errors were encountered: