Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json is missing @opentelemetry/core in peerDependencies #127

Closed
Aghassi opened this issue Apr 25, 2024 · 1 comment
Closed

package.json is missing @opentelemetry/core in peerDependencies #127

Aghassi opened this issue Apr 25, 2024 · 1 comment
Assignees
@wolfgangcodes
Labels
type: bug Something isn't working

Comments

@Aghassi
Copy link
Contributor

Aghassi commented Apr 25, 2024

Versions
0.1.1

Steps to reproduce

  1. In a project using pnpm and webpack install this package without adding any additional dependencies
  2. Attempt to import this package and bundle it with webpack
  3. Webpack should throw and an error for not finding @opentelemetry/core. This is because this package never specifies it in package.json and thus will never be resolved.

Additional context
pnpm and newer versions of yarn require maintainers to specify packages they don't bundle but are expected to have as peer dependencies. Otherwise, you are relying on the dependency manager to hoist the dependency which is never guaranteed. It's best to specify these packages as peer dependencies with major ranges unless you need a specific version
@Aghassi Aghassi added the type: bug Something isn't working label Apr 25, 2024
Aghassi added a commit to Aghassi/honeycomb-opentelemetry-web that referenced this issue Apr 25, 2024
@Aghassi
add opentelemetry/core as a peerdependency to package.json
85b9fcf 
Solves honeycombio#127 

This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies
@Aghassi Aghassi mentioned this issue Apr 25, 2024
Closed
Aghassi added a commit to Aghassi/honeycomb-opentelemetry-web that referenced this issue Apr 25, 2024
@Aghassi
add opentelemetry/core as a peerdependency to package.json
082eb2b 
Solves honeycombio#127

This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies
Aghassi added a commit to Aghassi/honeycomb-opentelemetry-web that referenced this issue Apr 25, 2024
@Aghassi
fix: add opentelemetry/core as a peerdependency to package.json
ae4275f 
Solves honeycombio#127

This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies
Aghassi added a commit to Aghassi/honeycomb-opentelemetry-web that referenced this issue Apr 30, 2024
@Aghassi
fix: add opentelemetry/core as a peerdependency to package.json
1953ea2 
Solves honeycombio#127

This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies
MustafaHaddara pushed a commit that referenced this issue May 1, 2024
@Aghassi @MustafaHaddara
fix: add opentelemetry/core as a peerdependency to package.json
3aaabbc 
Solves #127

This will fix support for package managers like `pnpm` that require you to be very explicit about your dependencies

Co-authored-by: David <[email protected]>
@MustafaHaddara MustafaHaddara mentioned this issue May 1, 2024
Merged
MustafaHaddara added a commit that referenced this issue May 1, 2024
@MustafaHaddara @Aghassi
fix: add opentelemetry/core as a peerdependency to package.json (#136)
b8a0130 
Solves #127
Closes #128 

This will fix support for package managers like `pnpm` that require you
to be very explicit about your dependencies

## Which problem is this PR solving?

Closes #128 

@Aghassi contributed a fix in that PR but we merged other PRs and
created merge conflicts. This PR resolves those merge conflicts on their
behalf.

Co-authored-by: David <[email protected]>
@wolfgangcodes wolfgangcodes self-assigned this Aug 12, 2024
@wolfgangcodes
Copy link
Contributor

Hi @Aghassi! @opentelemetry/core was explicitly added as to dependencies in PR #136, so we'll track splitting dependencies from peerDependencies in issue #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfgangcodes wolfgangcodes

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add opentelemetry/core as a dependency to package.json Aghassi/honeycomb-opentelemetry-web
2 participants
@wolfgangcodes @Aghassi