From c38862779d391b96051bd0c6890c221d983419e2 Mon Sep 17 00:00:00 2001 From: Mohamed Barakat Date: Sun, 2 Jul 2023 17:15:15 +0200 Subject: [PATCH 1/2] fixed order of line in example file --- ExamplesForHomalg/PackageInfo.g | 2 +- ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ExamplesForHomalg/PackageInfo.g b/ExamplesForHomalg/PackageInfo.g index ec2cf7363..c94117dad 100644 --- a/ExamplesForHomalg/PackageInfo.g +++ b/ExamplesForHomalg/PackageInfo.g @@ -11,7 +11,7 @@ SetPackageInfo( rec( PackageName := "ExamplesForHomalg", Subtitle := "Examples for the GAP Package homalg", -Version := "2023.02-04", +Version := "2023.07-01", Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ), License := "GPL-2.0-or-later", diff --git a/ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g b/ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g index e35724446..a40332341 100644 --- a/ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g +++ b/ExamplesForHomalg/examples/Oscar/ReducedBasisOfModule.g @@ -1,7 +1,7 @@ -homalgIOMode("d"); - LoadPackage( "RingsForHomalg" ); +homalgIOMode("d"); + Qxyz := HomalgFieldOfRationalsInOscar( ) * "x,y,z"; wmat := HomalgMatrix( "[ \ From c3550165290edd19d428831fed5d93bb695efcf3 Mon Sep 17 00:00:00 2001 From: Mohamed Barakat Date: Sun, 2 Jul 2023 17:15:56 +0200 Subject: [PATCH 2/2] ListImpliedFilters now includes the filter itself --- ToolsForHomalg/PackageInfo.g | 2 +- ToolsForHomalg/gap/ToolsForHomalg.gd | 3 ++- ToolsForHomalg/gap/ToolsForHomalg.gi | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ToolsForHomalg/PackageInfo.g b/ToolsForHomalg/PackageInfo.g index 90fca7028..576e72248 100644 --- a/ToolsForHomalg/PackageInfo.g +++ b/ToolsForHomalg/PackageInfo.g @@ -10,7 +10,7 @@ SetPackageInfo( rec( PackageName := "ToolsForHomalg", Subtitle := "Special methods and knowledge propagation tools", -Version := "2023.05-01", +Version := "2023.07-01", Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ), License := "GPL-2.0-or-later", diff --git a/ToolsForHomalg/gap/ToolsForHomalg.gd b/ToolsForHomalg/gap/ToolsForHomalg.gd index bf3e4d02e..63f54cb09 100644 --- a/ToolsForHomalg/gap/ToolsForHomalg.gd +++ b/ToolsForHomalg/gap/ToolsForHomalg.gd @@ -527,7 +527,8 @@ DeclareGlobalFunction( "StopTimer" ); DeclareGlobalFunction( "DisplayTimer" ); #! @Description -#! List the all filters implied by filter filt. +#! The input is a filter filt. +#! The output is the list of all filters implied by filt, including filt itself. #! @Arguments filt DeclareGlobalFunction( "ListImpliedFilters" ); diff --git a/ToolsForHomalg/gap/ToolsForHomalg.gi b/ToolsForHomalg/gap/ToolsForHomalg.gi index 062b4cfd6..6441e56f6 100644 --- a/ToolsForHomalg/gap/ToolsForHomalg.gi +++ b/ToolsForHomalg/gap/ToolsForHomalg.gi @@ -2737,7 +2737,7 @@ InstallGlobalFunction( ListImpliedFilters, od; end; - list := [ ]; + list := [ NamesFilter( filter )[1] ]; if SIZE_FLAGS(implied) > 0 then Append( list, NamesFilter( reduced( TRUES_FLAGS( implied ) ) ) );