Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace dprint escape sequence in generated types.ts file #322

Open
c12i opened this issue Jul 8, 2024 · 1 comment
Open

fix: replace dprint escape sequence in generated types.ts file #322

c12i opened this issue Jul 8, 2024 · 1 comment
Assignees

Comments

@c12i
Copy link
Collaborator

c12i commented Jul 8, 2024

Currently code generated in types.ts contains a dprint /* dprint-ignore-start */ comment to prevent the initial EntryTypes type alias from getting formatted thereby causing errors when attempting to populate the members of this union type on subsequent hc scaffold entry-type runs. This is internal implementation that is getting leaked here and should ideally be hidden.

@c12i c12i self-assigned this Jul 8, 2024
@c12i c12i added this to Holochain Oct 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Holochain Oct 15, 2024
@jost-s jost-s moved this from Backlog to Awaiting clarification in Holochain Nov 19, 2024
@c12i
Copy link
Collaborator Author

c12i commented Nov 19, 2024

Next Steps

For now, since a fully fledged solution is not yet available for this, a comment with a link to this issue can be added to the scaffolded types.ts to inform the hApp dev about why this escape sequence is there to begin with.

@c12i c12i self-assigned this Nov 21, 2024
@c12i c12i moved this from Awaiting clarification to Ready in Holochain Nov 28, 2024
@c12i c12i moved this from Ready to Awaiting clarification in Holochain Nov 28, 2024
@c12i c12i moved this from Awaiting clarification to Ready in Holochain Dec 12, 2024
@c12i c12i moved this from Ready to Awaiting clarification in Holochain Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting clarification
Development

No branches or pull requests

1 participant