refactor(clone-cell)!: return cell info for clone operations #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/create-clone-cell-returns-cell-info
maackle
requested changes
Jan 17, 2023
maackle
approved these changes
Jan 17, 2023
…r/create-clone-cell-returns-cell-info
* Write failing test for disabling clones * Fix problem where disabled clones are started at conductor restart * Fixes for macos (#1777) * chore: update holonix version * chore(nix):fix dev shell for macos * chore(kitsune_p2p/types): update sysinfo to fix build * chore(nix): update holonix version * chore(nix): remove crate2nix override * chore(nix): revert disabling crate2nix for macos * chore(nix): update holonix * dummy commit to trigger CI * chore(nix): use crate2nix from nixpkgs * docs(readme): remove chat + forum and add Discord link (#1778) * Add Discord link to Readme Removed the link to chat.holochain.net and in its place added the discord server link to the readme * Update README.md * countersigning top level docs (#1768) * countersigning top level docs * Update crates/hdk/src/lib.rs Co-authored-by: Jost Schulte <[email protected]> * Update crates/hdk/src/lib.rs Co-authored-by: Jost Schulte <[email protected]> Co-authored-by: Jost Schulte <[email protected]> * fix(app-install): reject duplicate identical cells (#1773) * add failing test for two identical apps install * add failing test for duplicate app installation * check there's no identical running cell when installng an app * update changelog * search through all cells for identical cell * add specific error for duplicate cells * clippy: combine find & is_some() to any * document call_info in hdk (#1765) * Apply suggestions from code review Co-authored-by: Jost Schulte <[email protected]> * remove docs saying links are to entries (#1767) Co-authored-by: DavHau <[email protected]> Co-authored-by: Abraham Njama <[email protected]> Co-authored-by: David Meister <[email protected]> Co-authored-by: Jost Schulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CreateCloneCellreturnsCellInfoinstead ofInstalledCell.EnableCloneCellreturnsCellInfoinstead ofInstalledCell.CellInfovariants are renamed to snake case during serde.SignalSubscription.Fixes holochain/holochain-client-js#161
TODO: