From 1f0e59bbdb94a07f7232594b3a329909898549df Mon Sep 17 00:00:00 2001 From: Tony Worm <1390600+verdverm@users.noreply.github.com> Date: Sun, 15 Dec 2024 17:28:00 -0500 Subject: [PATCH] cmd/feedback: remove flag shorthands that are conflicting with global flags (#399) Co-authored-by: Tony Worm --- .hof/shadow/cli/cmd/hof/flags/feedback.go | 4 ++-- cmd/hof/flags/feedback.go | 4 ++-- design/cmds/feedback.cue | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.hof/shadow/cli/cmd/hof/flags/feedback.go b/.hof/shadow/cli/cmd/hof/flags/feedback.go index 39cab28cd..5cd29c724 100644 --- a/.hof/shadow/cli/cmd/hof/flags/feedback.go +++ b/.hof/shadow/cli/cmd/hof/flags/feedback.go @@ -16,8 +16,8 @@ type FeedbackPflagpole struct { func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) { // pflags - fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)") - fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated") + fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)") + fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated") } var FeedbackPflags FeedbackPflagpole diff --git a/cmd/hof/flags/feedback.go b/cmd/hof/flags/feedback.go index 39cab28cd..5cd29c724 100644 --- a/cmd/hof/flags/feedback.go +++ b/cmd/hof/flags/feedback.go @@ -16,8 +16,8 @@ type FeedbackPflagpole struct { func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) { // pflags - fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)") - fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated") + fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)") + fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated") } var FeedbackPflags FeedbackPflagpole diff --git a/design/cmds/feedback.cue b/design/cmds/feedback.cue index 4c807aeb5..6aeaacae6 100644 --- a/design/cmds/feedback.cue +++ b/design/cmds/feedback.cue @@ -17,14 +17,14 @@ FeedbackCommand: schema.Command & { Pflags: [{ Name: "issue" Long: "issue" - Short: "I" + Short: "" Type: "bool" Default: "false" Help: "create an issue (discussion is default)" }, { Name: "labels" Long: "labels" - Short: "L" + Short: "" Type: "string" Default: "\"feedback\"" Help: "labels,comma,separated"