Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referer not validated in LanguageSwitchController #65

Open
ChrisHillCap opened this issue Mar 5, 2019 · 0 comments
Open

Referer not validated in LanguageSwitchController #65

ChrisHillCap opened this issue Mar 5, 2019 · 0 comments

Comments

@ChrisHillCap
Copy link

I have noticed a minor security flaw with hmrc-frontend-scaffold

hmrc-frontend-scaffold.g8/src/main/g8/app/controllers/LanguageSwitchController.scala

Line 31 in a679a6d

val redirectURL = request.headers.get(REFERER).getOrElse(fallbackURL)

there should be some validation on this url (REFERER) before we automatically redirect the user back to it.
perhaps a check of domain being gov domain?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisHillCap