Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackagedProductDefinition: rename containedItemQuantity #16

Closed
rlindstrm opened this issue Oct 10, 2022 · 6 comments
Closed

PackagedProductDefinition: rename containedItemQuantity #16

rlindstrm opened this issue Oct 10, 2022 · 6 comments

Comments

@rlindstrm
Copy link
Collaborator

PackagedProductDefinition contains containedItemQuantity and package.containedItem.amount:

image
[..................................]
image

It has been indicated that very similar names for these attributes cause confusion.
We suggest renaming containedItemQuantity into packSize or totalAmount to be absolutely clear what it is used for.

@gcangioli
Copy link
Contributor

has been this item added as jira comment already ?

@rlindstrm
Copy link
Collaborator Author

Not by me. I am not advanced enough for that, I just filed everything here.

@gcangioli
Copy link
Contributor

I'm going to add this...

@rastegwee
Copy link

Not seeing a JIRA issue to vote on.

@gcangioli
Copy link
Contributor

@rastegwee
Copy link

Thanks! It seems to be the same issue that you included elsewhere, as my Neg Vote was already registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants