Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_include:iterate=PackagedProductDefinition:manufactured-item does not work properly #125

Open
G-DPP opened this issue Apr 19, 2023 · 4 comments

Comments

@G-DPP
Copy link
Collaborator

G-DPP commented Apr 19, 2023

The visualizer does not show the ManufacturedItemDefinition (#124) because the query in get does not return it.
The visualizer query is as follows:

https://jpa.unicom.datawizard.it/fhir/MedicinalProductDefinition?_id=Hipres-10mg-Tablet-EE-MPD&_revinclude=RegulatedAuthorization:subject&_include:iterate=RegulatedAuthorization:holder&_revinclude=PackagedProductDefinition:package-for&_include:iterate=PackagedProductDefinition:manufactured-item&_revinclude=AdministrableProductDefinition:form-of&_revinclude:iterate=Ingredient:for&_format=json

The ManufacturedItemDefinition is not present in the returned bundle while in this request it is:

https://jpa.unicom.datawizard.it/fhir/MedicinalProductDefinition?_id=ABIS-tablet-10mg--0-ITA-MPD&_revinclude=RegulatedAuthorization:subject&_include:iterate=RegulatedAuthorization:holder&_revinclude=PackagedProductDefinition:package-for&_include:iterate=PackagedProductDefinition:*&_revinclude=AdministrableProductDefinition:form-of&_revinclude:iterate=Ingredient:for&_format=json

The difference between the requests is in the _include parameter.
In the first request there is:
...&_include:iterate=PackagedProductDefinition:manufactured-item&...
In the second request:
...&_include:iterate=PackagedProductDefinition:*&...

@G-DPP G-DPP changed the title PackageProductDefinition _include:iterate=PackagedProductDefinition:manufactured-item does not work properly _include:iterate=PackagedProductDefinition:manufactured-item does not work properly Apr 19, 2023
@joofio
Copy link
Collaborator

joofio commented Apr 21, 2023

So...

From my study, I think this version of JPA start has a bug with the searchParameter for PackagedProductDefinition:manufactured-item.

this does not work:

https://jpa.unicom.datawizard.it/fhir/PackagedProductDefinition?manufactured-item=ManufacturedItemDefinition/Hipres-10mg-Tablet-EE-MID

But this works:

https://jpa.unicom.datawizard.it/fhir/PackagedProductDefinition?package-for=MedicinalProductDefinition/Hipres-10mg-Tablet-EE-MPD

Tested again with my own server (latest version of docker (or at least it was a few days ago) and this returns ok:

http://fhir.hl7.pt:8080/fhir/PackagedProductDefinition?manufactured-item=ManufacturedItemDefinition/Panodil500mgoralsolutionsachet-SE-PLC-MID

So i would suggest two lines of action:

  1. keep the * in the query for the time being since the references in the packagedproductdefinition are only for resources needed in the viz
  2. Update the JPA starter.

I would advise for keeping the * for the time being in order to keep it stable for next week and then upgrade.

@rlindstrm
Copy link
Collaborator

Is this solved?

@rlindstrm
Copy link
Collaborator

@costateixeira Can you fix it?
Joao's docker server is not showing manufactured items in product browser.

@joofio
Copy link
Collaborator

joofio commented Nov 22, 2023

linked to testlab viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants