Feature/1339/onboarding wizard adjustments #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
reviewed
Dec 12, 2024
There was a problem hiding this comment.
I found some other occurrences of "SAC Geschäftsstelle":
config/locales/wagon.de.yml
604: one: SAC Geschäftsstelle
605: other: SAC Geschäftsstelle
app/domain/sac_imports/roles/nav2b_base.rb
70: in [Group::SacCas => parent, "SAC Geschäftsstelle"]
doc/hierarchy.md
7: * SAC Geschäftsstelle
doc/oidc-claims.md
57: "group_name": "SAC Geschäftsstelle",
95: "group_name": "SAC Geschäftsstelle",
rnestler
reviewed
Dec 12, 2024
Saw that too 😄 Since it was not reported we leave it as it is right now and ask if they want to change it everywhere, This PR should only changes the ones related to the onboarding wizard |
rnestler
approved these changes
Dec 12, 2024
njaeggi
force-pushed
the
feature/1339/onboarding-wizard-adjustments
branch
from
7bcfad8 to
53de7a0
Compare
njaeggi
force-pushed
the
feature/1339/onboarding-wizard-adjustments
branch
from
53de7a0 to
3242436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.