Import/nav18 events #1367
Merged
Import/nav18 events #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWalkingLeek
commented
Dec 10, 2024
| @@ -84,6 +84,8 @@ def any_email_possible? | |||
| private | |||
|
|
|||
| def assert_valid_state_change | |||
| return if new_record? | |||
There was a problem hiding this comment.
Diese Validierung schlägt beim Import immer fehl da state_was immer nil ist. Ich gehe davon aus das liegt daran dass wir erst das ActiveRecord Objekt initialisieren und anschliessend attributes assignen.
codez
force-pushed
the
import/nav18-events
branch
5 times, most recently
from
a1d242e to
6a4c097
Compare
codez
force-pushed
the
import/nav18-events
branch
from
550573f to
78cf2f8
Compare
codez
force-pushed
the
import/nav18-events
branch
from
78cf2f8 to
c58e450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aktuell werden nur ca. 300 Kurse importiert. Es schlagen noch viele Validierungen aus (oftmals aufgrund https://github.com/hitobito/hitobito_sac_cas/blob/master/app/models/sac_cas/event/course.rb#L170 glaube ich).
ToDos: