Redirect to group person path if not able to show person (#1370)

* Redirect to group person path if not able to show person * Adjust specs --------- Co-authored-by: Robin <[email protected]>
hitobito · Dec 12, 2024 · 926eb84 · 926eb84
1 parent 3485634
commit 926eb84
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/controllers/memberships/terminate_sac_memberships_controller.rb b/app/controllers/memberships/terminate_sac_memberships_controller.rb
@@ -38,7 +38,13 @@ def success_message
 
     # NOTE: format: :html is required otherwise it is redirect as turbo_stream
     def redirect_target
-      person_path(person, format: :html)
+      # if the current_user does not have the ability to show the person in other groups the person has (or will have) roles
+      # in, we redirect to the member list and display the flash message there
+      if can?(:show, person)
+        person_path(person, format: :html)
+      else
+        group_people_path(group, format: :html)
+      end
     end
 
     def person

diff --git a/spec/requests/memberships/terminate_sac_memberships_controller_spec.rb b/spec/requests/memberships/terminate_sac_memberships_controller_spec.rb
@@ -201,7 +201,7 @@ def expect_terminated_page
         end
           .to change(Role, :count).by(-2)
           .and change { role.termination_reason_id }.from(nil).to(termination_reason_id)
-        expect(response).to redirect_to person_path(person, format: :html)
+        expect(response).to redirect_to group_people_path(groups(:bluemlisalp), format: :html)
         expect(flash[:notice]).to eq "Deine SAC-Mitgliedschaft wurde gekündet."
       end
     end