Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make postConditionFromMode public #1772

Open
aryzing opened this issue Nov 28, 2024 · 0 comments
Open

Make postConditionFromMode public #1772

aryzing opened this issue Nov 28, 2024 · 0 comments
Labels
feature Brand new functionality. New pages, workflows, endpoints, etc.

Comments

@aryzing
Copy link

aryzing commented Nov 28, 2024

Problem

@stacksjs/transactions makes both post condition mode types available as exports:

export type PostConditionModeName = 'allow' | 'deny';

export enum PostConditionMode {

but not the helper to that unifies into a single type,

export function postConditionModeFrom(

which makes it hard for clients to likewise allow for both types, and treat them in a stable manenr

Solution

Make postConditionModeFrom available for import for clients.

Additional context

Let me know if there's a better or preferred way of handling these two types, or if one will be soon deprecated?

@aryzing aryzing added the feature Brand new functionality. New pages, workflows, endpoints, etc. label Nov 28, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new functionality. New pages, workflows, endpoints, etc.
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant