Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle re-orgs for the ft/nft metadata tables #639

Closed
asimm241 opened this issue Jul 7, 2021 · 7 comments
Closed

Handle re-orgs for the ft/nft metadata tables #639

asimm241 opened this issue Jul 7, 2021 · 7 comments
Labels
P4 Priority 4 Edge cases, improvements, items to be refactored soon

Comments

@asimm241
Copy link
Contributor

asimm241 commented Jul 7, 2021

Describe the bug
There are forking scenarios that aren't handled by the queries against the ft_metadata and nft_metadata tables.

See details here : #576 (comment)
@asimm241 asimm241 mentioned this issue Jul 7, 2021
Merged
8 tasks
@agraebe agraebe added the P1 Priority 1 Critical functionality not working Impacts all/most customers label Jul 13, 2021
@asimm241
Copy link
Contributor Author

@zone117x do we need to add microblock_hash, microblock_sequence, microblock_canonical to these tables as well in addition to canonical. ?

@zone117x
Copy link
Member

Correct

@asimm241 asimm241 self-assigned this Jul 27, 2021
@agraebe agraebe added P2 Priority 2 Critical functionality not working Impacts one/few customers and removed P1 Priority 1 Critical functionality not working Impacts all/most customers labels Aug 10, 2021
@agraebe agraebe linked a pull request Aug 23, 2021 that will close this issue
Feat/tokens metadata #576
Merged
8 tasks
@asimm241 asimm241 mentioned this issue Aug 24, 2021
Closed
9 tasks
@asimm241 asimm241 linked a pull request Aug 24, 2021 that will close this issue
handle re-orgs for ft and nft metadata #721
Closed
9 tasks
@agraebe agraebe removed a link to a pull request Sep 13, 2021
Feat/tokens metadata #576
Merged
8 tasks
@asimm241 asimm241 removed the P2 Priority 2 Critical functionality not working Impacts one/few customers label Sep 22, 2021
@andresgalante andresgalante moved this to Icebox in API Board Nov 3, 2021
@sabbyanandan
Copy link

A lot of rich dialog and commentary at #576, which attempts to address the said bug(s). Not entirely clear whether we are kosher with the improvements or what is pending.

Perhaps @asimm241, if you could clarify what remains, it would help very much. 🙏🏽

@asimm241
Copy link
Contributor Author

asimm241 commented Mar 5, 2022

@sabbyanandan I'm not sure but I think this should be closed now. We decided to work on it after the #743
but then It was decided that we are not going to implement #743. So this issue should be closed now.

@sabbyanandan
Copy link

Thanks for checking and the follow-up, @asimm241.

Repository owner moved this from Icebox to Done in API Board Mar 7, 2022
@zone117x
Copy link
Member

#743 is unrelated to this task which I believe is still outstanding

@zone117x zone117x reopened this Mar 12, 2022
Repository owner moved this from Done to Recent issues in API Board Mar 12, 2022
@rafaelcr rafaelcr added the P4 Priority 4 Edge cases, improvements, items to be refactored soon label Mar 22, 2022
@rafaelcr rafaelcr moved this from Recent issues to Backlog in API Board Mar 22, 2022
@asimm241 asimm241 removed their assignment Jun 1, 2022
@rafaelcr
Copy link
Collaborator

Deprecated by #1222

Repository owner moved this from Backlog to Done in API Board Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 Priority 4 Edge cases, improvements, items to be refactored soon
Projects
API Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle re-orgs for ft and nft metadata hirosystems/stacks-blockchain-api
5 participants
@rafaelcr @zone117x @sabbyanandan @agraebe @asimm241