Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Deno 1.28 npm import features #702

Closed
hstove opened this issue Dec 5, 2022 · 2 comments
Closed

Incorporate Deno 1.28 npm import features #702

hstove opened this issue Dec 5, 2022 · 2 comments
Assignees
Milestone

Comments

@hstove
Copy link
Contributor

hstove commented Dec 5, 2022

Deno 1.28 came with the really cool feature of supporting NPM imports. I find this really helpful, and there are a few NPM packages (like micro-stacks, bitcoinjs-lib, etc) that I would really like to use in my tests. At the moment, I have to do some hacky workarounds when I need to use a NPM package that I can't easily re-write.

I know there were some changes around how Deno is vendored, but I'm not able to parse how that works in Clarinet exactly. Is deno_graph the relevant dependency here? I tried updating that to latest, but that threw a few errors when building.

@blockstack-devops blockstack-devops moved this to 🆕 New in DevTools Dec 5, 2022
@saralab saralab moved this from 🆕 New to 🔖 To do in DevTools Dec 6, 2022
@hugocaillard hugocaillard added this to the Q1-2023 milestone Dec 6, 2022
@lgalabru lgalabru moved this from 🔖 To do to ❄️ Icebox in DevTools Feb 2, 2023
@hstove
Copy link
Contributor Author

hstove commented Feb 7, 2023

Hey - curious what the outlook for this is? I have no idea how the internals of Clarinet's Deno code works, so I'm not sure how big of a lift this is. I find myself wanting this feature more and more. For example, I have code that does things like generate a Bitcoin payload or signed message, and the only good libraries are on NPM. Right now, I have to have separate scripts (even in Deno!) that create mock data, which I can separately import into my tests. It's just a hassle and I'd love to be able to do this without separate scripts.

@sabbyanandan sabbyanandan removed this from the Q1-2023 milestone May 4, 2023
@hugocaillard
Copy link
Collaborator

hugocaillard commented Jun 15, 2023

Still kind of relevant, but will be handled with the approach in #1052
Closing this one
(Let me know if you have feedback regarding #1052 @hstove 🙏 )

@hugocaillard hugocaillard closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@github-project-automation github-project-automation bot moved this from ❄️ Icebox to ✅ Done in DevTools Jun 15, 2023
@smcclellan smcclellan added this to the Q2-2023 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants