Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent onDestroy when back is clicked #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hgapsilva
Copy link

when having native with a react native fragment, after entering that fragment and then using the back hardware, the app crashes

when having native with a react native fragment, after entering that fragment and then using the back hardware, the app crashes
@hgapsilva hgapsilva changed the title Update VolumeManagerModule.java fix: onDestroy VolumeManagerModule.java Jan 24, 2024
@hgapsilva hgapsilva changed the title fix: onDestroy VolumeManagerModule.java fix: prevent onDestroy when back is clicked Jan 24, 2024
@hirbod
Copy link
Owner

hirbod commented Feb 1, 2024

Hi @hgapsilva,

thanks for your PR. I'll verify it this weekend and create a new release once I am adding support for 0.73

hirbod

This comment was marked as duplicate.

@chrysb
Copy link

chrysb commented Mar 27, 2024

Can you please merge this? It's almost been two months and this is crashing our app.

@hgapsilva hgapsilva closed this Aug 16, 2024
@hgapsilva hgapsilva reopened this Aug 16, 2024
@hgapsilva hgapsilva requested a review from hirbod August 16, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants