Move .flake8 config to pyproject.toml #1377
AlexanderHott
started this conversation in
Ideas
Replies: 1 comment
-
This is just a left-over from when we had the plugin enabled
That is the reason we initially disabled it.
Feel free to! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As of flake8 0.5.0 (hikari uses 0.5.4), you are able to define the flake8 configuration inside of the pyproject.toml file via the Flake8-pyproject flake8 plugin.
This upgrade drops support for flake8-broken-line, but black already removes any backslashes.
The .flake8 file currently lists IFSTMT001 as one of the ignored codes, which I think should be IFS001, but hikari doesn't even use that flake8 plugin so it can just be removed. The 6 letter then 3 number code causes Flake8-pyproject to error, that's why I'm bringing this up.
All other tool configs are defined in the pyproject.toml, so I see no issue in moving it. I'd be happy to create a PR if this idea gets approved.
Beta Was this translation helpful? Give feedback.
All reactions