Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokenFeeScheduleUpdateTransaction): Implement tokenFeeScheduleUpdateTransaction E2E tests: TCK #268

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR implements the TokenFeeScheduleUpdateTransaction tests documented in test-specifications/token-service/tokenFeeScheduleUpdateTransaction.md. Currently some tests are skipped because of a potential bugs in the services code.

Related issue(s):
#248

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

rwalworth and others added 28 commits August 8, 2024 09:45
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…saction' into 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction

Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…o the skipped tests and fixed the docs

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing in C++

@rwalworth rwalworth requested a review from RickyLB November 7, 2024 20:34
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction branch from 9ca1c1f to 6c232d1 Compare November 18, 2024 11:08
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests passing with C++ server!

…leupdatetransaction

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction branch from 2626df3 to 1c0cd62 Compare December 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK: Implement tests for TokenFeeScheduleUpdateTransaction
3 participants