Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Account types to string from int64_t #856

Merged

Conversation

rwalworth
Copy link
Contributor

@rwalworth rwalworth commented Dec 9, 2024

Description:
This PR changes the int64_t types in createAccount and updateAccount to std::strings as a part of
hiero-ledger/hiero-sdk-tck#284.

Related issue(s):

Fixes #855

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Rob Walworth <[email protected]>
@rwalworth rwalworth added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Dec 9, 2024
@rwalworth rwalworth self-assigned this Dec 9, 2024
@rwalworth rwalworth requested review from a team as code owners December 9, 2024 22:25
@rwalworth rwalworth linked an issue Dec 9, 2024 that may be closed by this pull request
@gsstoykov gsstoykov merged commit 37ce60f into main Dec 10, 2024
3 checks passed
@gsstoykov gsstoykov deleted the 00855-tck-c++-update-account-types-from-int64-to-string branch December 10, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK-C++: Update Account types from int64 to string
2 participants