Add AccountCreationWaysExample
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalworth
added
Improvement
rwalworth
removed
the
Improvement
2 tasks
…Make AccountId private members public and remove setter-getter functions for them to more align with other SDKs Signed-off-by: Rob Walworth <[email protected]>
deyanzz
force-pushed
the
00492-implement-accountcreationwaysexample
branch
from
541a98c to
ad751ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
AccountCreationWaysExample, which shows users the different ways accounts can be represented.It also adds
AccountId::fromEvmAddress()to allow for Long-Zero account ID formats to be realized correctly, as well as more alignsAccountIds structure with other SDKs (most notably, make private member variables public and remove setter-getter functions).This also depends on work done in #487, so that PR should be reviewed and merged first.
Related issue(s):
Fixes #492
Checklist