-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds failing on Go 1.16rc1 #446
Comments
Hey, thanks for this report. I believe these are both from the changes described in the Modules section of the (draft) release notes. The bin/test issue is pretty straightforward to fix, I think, and I have an initial take at that locally. For the For your example, I think ultimately we'd like to run The changes to the go command in 1.16 won't allow mixing of versionless and versioned packages to The current
And each line would result in a separate invocation of I'll try that out locally. What do you think? |
Sorry I didn't call it out explicitly but you are totally right: another option for this is to say that with 1.16+ something like tools.go must be used. That is not my favorite since it does clutter your module with deps/etc related to the installed tool(s). Another similar option is to not support installing extra things in 1.16+, instead recommending some other method be used to fetch needed binaries. For example, the inline buildpack could be used in addition to the Go buildpack to fetch and install the latest migrate binary. |
Hey there, v152 of the buildpack was just published. That should fix the bin/test issue, please let me know if not. I haven't had a chance to create a change/fix for |
Ran into two separate issues with Go 1.16rc1, both related to changes in
go install
.1. The
+heroku install
directive no longer works with packages outside of the module.For example, I'm currently using it to install additional packages such as
golang-migrate
:In
go.mod
:// +heroku install -tags postgres . github.com/golang-migrate/migrate/v4/cmd/migrate
But build setup is now failing with an error:
One workaround is to force the package to be included in the module by adding a
tools.go
package, but this wasn't previously required. Might be helpful to add some docs about this somewhere.2. The
bin/test
command is failing because a package version isn't specified:The text was updated successfully, but these errors were encountered: