Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #26

Open
e271828- opened this issue Jul 26, 2023 · 11 comments
Open

Dark mode #26

e271828- opened this issue Jul 26, 2023 · 11 comments

Comments

@e271828-
Copy link

Please add dark mode support!

Both GitHub and Jira have it, so this makes the white popup jarring.

@aareman
Copy link
Contributor

aareman commented Dec 5, 2023

@e271828- I opened a PR #27 which adds dark mode based on browser preference.

@aareman
Copy link
Contributor

aareman commented Dec 6, 2023

@helmus when you get a chance, please lmk if there is anything else you would like me to do to make the PR merge-able? (#27 )

@aareman
Copy link
Contributor

aareman commented Dec 18, 2023

Following up about this @helmus I think this feature will be helpful to a lot of people.

@helmus
Copy link
Owner

helmus commented Dec 18, 2023

Can you share a screen recording of how you tested this ?

@aareman
Copy link
Contributor

aareman commented Dec 19, 2023 via email

@helmus
Copy link
Owner

helmus commented Dec 19, 2023

Can you try testing with a public jira instance like:
https://issues.apache.org/jira/projects/HIVE/issues/HIVE-26111?filter=allopenissues

@aareman
Copy link
Contributor

aareman commented Dec 19, 2023

jira_hotlinker.webm
Here is a video

@helmus
Copy link
Owner

helmus commented Dec 19, 2023

Great! , can you show it in white as well so we can confirm the current behavior still works.

@aareman
Copy link
Contributor

aareman commented Dec 19, 2023

image

@aareman
Copy link
Contributor

aareman commented Dec 19, 2023

Here is a video of both in action

jira.hotlinker.both.mp4

@helmus
Copy link
Owner

helmus commented Dec 19, 2023

Will release this later this week after I find the time to upgrade to the new manifest
https://developer.chrome.com/docs/extensions/develop/migrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants