From 19808d64d08d7e8866bc7ebe2e3da98119935933 Mon Sep 17 00:00:00 2001 From: Chris Sauer Date: Wed, 22 Feb 2023 02:30:55 -0800 Subject: [PATCH] Update sysroot notes now that https://github.com/hedronvision/bazel-compile-commands-extractor/issues/82 is closed --- refresh.template.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/refresh.template.py b/refresh.template.py index 1fd38c4..de3e8b8 100644 --- a/refresh.template.py +++ b/refresh.template.py @@ -735,8 +735,8 @@ def _all_platform_patch(compile_args: typing.List[str]): # For more context see: https://github.com/hedronvision/bazel-compile-commands-extractor/issues/21 compile_args = (arg for arg in compile_args if not arg == '-fno-canonical-system-headers') - # Swap -isysroot for --sysroot to work around (probably) https://github.com/clangd/clangd/issues/1305 - # For context, see https://github.com/clangd/clangd/issues/1305 + # Swap -isysroot for --sysroot to work around some unknown sysroot bug in clangd. + # For context, see https://github.com/hedronvision/bazel-compile-commands-extractor/issues/82 # The = logic has to do with clang not accepting -isysroot=, but accepting --sysroot=. Note that -isysroot is accepted, though undocumented. compile_args = ('-isysroot'+arg[len('--sysroot')+arg.startswith('--sysroot='):] if arg.startswith('--sysroot') else arg for arg in compile_args)