Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stimes should be defined on 0 for all monoids #56

Open
sol opened this issue Nov 17, 2023 · 1 comment
Open

stimes should be defined on 0 for all monoids #56

sol opened this issue Nov 17, 2023 · 1 comment

Comments

@sol
Copy link
Contributor

sol commented Nov 17, 2023

I assume that stimes 0 xs should be mempty for all monoids.

However, this is something that is easy to miss + many of the implementations out there are "broken" in that regard.

Should we test for this in monoidLaws?
@chessai
Copy link
Collaborator

chessai commented Nov 17, 2023

I assume that stimes 0 xs should be mempty for all monoids.

However, this is something that is easy to miss + many of the implementations out there are "broken" in that regard.

Should we test for this in monoidLaws?

Yes, sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sol @chessai