-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proc-macro-error as an abandonware dependency #83
Comments
My compile error, shown in my CI/CD pipeline
|
Steps to replicate:
|
will see what they're doing and maybe fork or find a fork, thank you for the heads-up! (for later use, this is the original:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran into an error in my CI/CD testing. I am performing a test where I compile all crate dependencies using the minimum valid version numbers. The bilge-impl crate fails to compile - although the error is in its dependency, the proc-macro-error crate. The proc-macro-error crate has a bug in version 1.0.0 which is fixed in its latest version, 1.0.4. However, because bilge-impl specifies the minimum proc-macro-error version as 1.0 instead of ^1.0.4, this error shows up when I do the minimum-version test.
The quick and easy fix is to specify the version number, and just change the bilge-impl Cargo.toml file dependency to
proc-macro-error = { version = "1.0.4", default-features = false }
I think that the quick fix would be wrong, however - it's clear that the proc-macro-error crate is abandoned. It doesn't have any updates since 3 years ago, its owner has no git history over the last year, and it is failing to keep up with some critical libraries - syn 2.0, for example.
To finish this out, I think that
(1) any proc-macro-error usage should be taken out of the codebase.
(2) this library should also implement a similar minimum version CI/CD test.
I'd be happy to help with both and submit a PR.
The text was updated successfully, but these errors were encountered: