Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #2

Open
negatratoron opened this issue Dec 26, 2017 · 0 comments
Open

Add tests #2

negatratoron opened this issue Dec 26, 2017 · 0 comments

Comments

@negatratoron
Copy link
Contributor

Each layout should be tested separately in isolation.

Additionally, full integration tests should be performed using a headless browser, in which we measure the sizes of HCJ components (particularly text and form elements under various user CSS rules) and make sure they are all sized correctly.
negatratoron added a commit that referenced this issue Apr 24, 2018
@negatratoron
stack: add components from top to bottom
bfda3eb 
Reverts ecebcd1

That will not be a valid fix for z-index, because it causes other
problems like <TAB> movement in forms going from bottom to top instead
of top to bottom.

(If HCJ had a test suite, I would certainly be adding a test case for
this... (see #2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@negatratoron