Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reusing HazelcastHealthIndicator for more consistent results #63

Open
snicoll opened this issue Mar 30, 2020 · 2 comments
Open
Assignees

Comments

@snicoll
Copy link

snicoll commented Mar 30, 2020

Rather than having a custom HazelcastJetHealthIndicator, please consider auto-configuring a standard org.springframework.boot.actuate.hazelcast.HazelcastHealthIndicator since all it does is checking the state of the embdded HazelcastInstance anyway.

@gurbuzali gurbuzali self-assigned this Mar 30, 2020
@gurbuzali
Copy link
Contributor

org.springframework.boot.actuate.hazelcast.HazelcastHealthIndicator uses com.hazelcast.core.Endpoint which has moved to com.hazelcast.cluster.Endpoint in 4.0. This prevents us to reuse HazelcastHealthIndicator. But if we change it to use the LifecycleService.isRunning instead of executing a transaction, we can re-visit this issue.

@snicoll
Copy link
Author

snicoll commented Mar 31, 2020

Ah good point, I haven't started to look at Hazelcast v4 compatibility yet. Perhaps you could take the Spring Boot version here and port it to the new API rather than creating a completely different one?

We can coordinate once Spring Boot upgrades to Hazelcast v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants