-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] hauler unable to parse complex file names #175
Comments
zackbradys@zacks-mbp Downloads % hauler store add file https://download.rockylinux.org/pub/rocky/9/BaseOS/x86_64/os/Packages/l/libstdc%2B%2B-11.4.1-2.1.el9.x86_64.rpm
Error: could not parse reference: libstdc%!B(MISSING)%!B(MISSING)-11.4.1-2.1.el9.x86_64.rpm
Usage:
hauler store add file [flags]
Flags:
-h, --help help for file
-n, --name string (Optional) Name to assign to file in store
Global Flags:
--cache string Location of where to store cache data (defaults to $XDG_CACHE_DIR/hauler)
-l, --log-level string (default "info")
-s, --store string Location to create store at (default "store")
10:37PM ERR could not parse reference: libstdc%!B(MISSING)%!B(MISSING)-11.4.1-2.1.el9.x86_64.rpm |
Hauler is not able to parse "%2B". Converting it to "+" does not work either. |
@clemenko thanks for the confirmation. the browser automatically generated the link with the zackbradys@zacks-mbp Downloads % hauler store add file https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/p/perl-TermReadKey-2.38-11.el9.x86_64.rpm
Error: could not parse reference: perl-TermReadKey-2.38-11.el9.x86_64.rpm
Usage:
hauler store add file [flags]
Flags:
-h, --help help for file
-n, --name string (Optional) Name to assign to file in store
Global Flags:
--cache string Location of where to store cache data (defaults to $XDG_CACHE_DIR/hauler)
-l, --log-level string (default "info")
-s, --store string Location to create store at (default "store")
8:19AM ERR could not parse reference: perl-TermReadKey-2.38-11.el9.x86_64.rpm |
Good catch. Names with "+" and upper case letters don't convert 1:1 into image refs. Let me get Hauler "files" doing some character conversions and that should fix this up. |
I sthis really fixed? In my case, the = is not in the file but in the path of the URL:
`apiVersion: content.hauler.cattle.io/v1alpha1
` Result: ` hauler store sync --store rke2-store --platform linux/amd64 --files manifest_files.yml -l debug8:38AM DBG running cli command [hauler store sync] With '+' in url: `
` Result: ` hauler store sync --store rke2-store --platform linux/amd64 --files manifest_files.yml -l debug8:39AM DBG running cli command [hauler store sync] ` Best regards, |
I think it's because you're putting the path in the You only want to use the for example....
|
Environmental Info:
Hauler Version:
System CPU architecture, OS, and Version:
Linux ip-172-31-34-117.ec2.internal 5.14.0-362.8.1.el9_3.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Nov 8 17:36:32 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Describe the bug:
hauler
with complex file names, or even with random file names that are not seemly complex, such as linux packages and/or rpms, it will fail to add to the store withhauler store add file
orhauler store sync
.hauler
manifest,hauler
"could not parse reference" for any name withperl
orlibstdc
Steps To Reproduce:
hauler store sync --store packages --files rancher-airgap-packages.yaml
Example Errors:
2:26AM ERR could not parse reference: perl-Time-Local-1.300-7.el9.noarch.rpm
2:28AM ERR could not parse reference: perl-MIME-Base64-3.16-4.el9.x86_64.rpm
2:31AM ERR could not parse reference: perl-TermReadKey-2.38-11.el9.x86_64.rpm
2:32AM ERR could not parse reference: libstdc++-11.4.1-2.1.el9.x86_64.rpm
Expected behavior:
hauler
Actual behavior:
hauler
Additional context / logs:
The text was updated successfully, but these errors were encountered: