Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude */man items from newyear.pl #197

Open
moseshll opened this issue Dec 4, 2024 · 0 comments
Open

Exclude */man items from newyear.pl #197

moseshll opened this issue Dec 4, 2024 · 0 comments
Labels
DRY Don't repeat yourself!

Comments

@moseshll
Copy link
Collaborator

moseshll commented Dec 4, 2024

We should not submit a New Year review for anything with current rights */man since it will silently fail.

bin/newyear.pl has in three places the clause next if $acurr eq 'pd' or $acurr =~ m/^cc/;.
Break this out into a new sub called current_rights_out_of_scope and add or $rcurr eq 'man' clause.
@moseshll moseshll added the DRY Don't repeat yourself! label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DRY Don't repeat yourself!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moseshll