Remove GHC <= 9.0 from the support window #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchoutri
force-pushed
the
remove-support-for-8.10.7
branch
5 times, most recently
from
4a12fe4
to
a9ab6df
Compare
tchoutri
force-pushed
the
remove-support-for-8.10.7
branch
from
a9ab6df
to
1dbe410
Compare
|
@ysangkok I'd love a review :) |
ysangkok
requested changes
Aug 30, 2024
changelog.d/1778
Outdated
| prs: #1778 | ||
|
|
||
| description { | ||
| GHC <= 8.10.7 is removed from the support window. The lowest version supported in CI becomes GHC 9.2.1, released on the 29/10/2021. |
There was a problem hiding this comment.
If the lower base bound is 4.16.4.0, then that corresponds to 9.2.5, not 9.2.1. So I think this should say 9.2.5
There was a problem hiding this comment.
you're right, actually latest patch version of 9.2 (9.2.8) should be the one we should aim
tchoutri
force-pushed
the
remove-support-for-8.10.7
branch
2 times, most recently
from
601a00c
to
287d50b
Compare
ysangkok
requested changes
Sep 2, 2024
GHC <= 8.10.7 is removed from the support window. The lowest version supported in CI becomes GHC 9.2.1, released on the 29/10/2021. This grants us the ability to use `-XGHC2021` as default language, as well as `-XOverloadedRecordDot`.
tchoutri
force-pushed
the
remove-support-for-8.10.7
branch
from
287d50b
to
07b0943
Compare
tchoutri
changed the title
|
Missing minimum bytestring bumps for:
Missing minimum container bumps for:
|
|
@ysangkok alright, I believe I have answered your reviews. |
ysangkok
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC <= 9.0 is removed from the support window. The lowest version supported in CI becomes GHC 9.2.8, released on the 26/05/2023
This grants us the ability to use
-XGHC2021as default language, as well as-XOverloadedRecordDot.