Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add servant-client-ghcjs to hackage and stackage #939

Closed
tysonzero opened this issue Apr 8, 2018 · 13 comments
Closed

Add servant-client-ghcjs to hackage and stackage #939

tysonzero opened this issue Apr 8, 2018 · 13 comments

Comments

@tysonzero
Copy link

tysonzero commented Apr 8, 2018

Title, it would be convenient to be able to install it from Hackage/Stackage. I'm assuming the current recommended way to install it is via Github?

@tysonzero tysonzero changed the title Add servant-client-ghcjs to hackage Add servant-client-ghcjs to hackage and stackage Apr 8, 2018
@phadej
Copy link
Contributor

phadej commented Apr 9, 2018

Yes, currently from GitHub

@tysonzero
Copy link
Author

Alright will do, any ETA on when it will be on hackage / stackage etc.?

@alpmestan
Copy link
Contributor

Were we not stuck on CI for servant-client-ghcjs?

@phadej
Copy link
Contributor

phadej commented Apr 9, 2018 via email

@ElvishJerricco
Copy link

If you're using the ghcjs-dom for all browser calls and not the JS FFI, you don't need to do anything to build with GHC. It will automatically fallback to the jsaddle backend.

@arianvp
Copy link
Member

arianvp commented Apr 13, 2018

Oh that would be interesting. @FPtje do you know about the ghcjs-dom package?
We could at least use it to make servant-client-ghcjs run on GHC and run the unit tests. A more noble goal would be to merge servant-client and servant-client-ghcjs but that would be a next step.

@FPtje
Copy link
Contributor

FPtje commented Apr 13, 2018

I do, yeah. I've refrained from using it because its jsaddle dependency is a rather bulky one.

By the way, I'm sure we can make servant-client-ghcjs build with ghc, but that might give the false impression that it also actually works with ghc. That might be technically possible with jsaddle, but I reckon it still wouldn't be desirable because servant-client would be the right choice anyway. To get it to work on CI I'd recommend trying to get the ghcjs compiler to work.

@ElvishJerricco
Copy link

I would recommend getting this to work via jsaddle. The ability to run reflex-dom apps via GHC+jsaddle is critical to my productivity with it. Dev cycles are literally an order of magnitude faster when you can :r in GHCi instead of waiting on GHCJS's slow compile times. When building frontends with GHC+jsaddle, it would be far more desirable to be able to use the same client library, knowing that it's using the same browser API that the GHCJS app will be using.

@roberth
Copy link
Contributor

roberth commented Apr 22, 2018

@ElvishJerricco are you looking for this? servant-client-jsaddle.

If anyone wants to move it into this repo, I'd be all for it.

@alpmestan
Copy link
Contributor

alpmestan commented Jul 28, 2018

Sorry, I somehow missed this. Yes we could certainly move it under haskell-servant. Still interested?

@roberth
Copy link
Contributor

roberth commented Jul 28, 2018

@alpmestan See #1018

@phadej
Copy link
Contributor

phadej commented Jan 9, 2020

I migrated servant-jsaddle to own repository, I consider the two remaining issues haskell-servant/servant-jsaddle#2 and haskell-servant/servant-jsaddle#1 blocking the release.

Closing this issue in favour of the other two.

@phadej phadej closed this as completed Jan 9, 2020
@tysonzero
Copy link
Author

tysonzero commented May 31, 2020

I don't see how those issues address servant-client-ghcjs being on hackage/stackage.

Currently whenever I upgrade our stack I have to figure out what servant-* versions are being pulled from hackage and find a compatible git commit to pull servant-client-ghcjs from so that they co-operate. It's a pretty huge PITA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants