Improving support for polymorphic data types #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePors
commented
Oct 31, 2019
| @@ -522,6 +522,8 @@ renderDecoderName elmTypeExpr = | |||
| parens ("Json.Decode.list " <> parens (renderDecoderName t)) | |||
| ETyApp (ETyCon (ETCon "Maybe")) t -> | |||
| parens ("Json.Decode.maybe " <> parens (renderDecoderName t)) | |||
| ETyApp x y -> | |||
| parens (renderDecoderName x <+> renderDecoderName y) | |||
There was a problem hiding this comment.
Previously my use case would have been handled by the default case below (which renders spaces and parentheses). This change will render the decoder for x and will then render the decoder for y as an input to the decoder for x.
Example: If x ~ "Either" and y ~ "List String" then x -> jsonDecEither and y -> (Json.Decode.list Json.string) so ETyApp x y -> (jsonDecEither (Json.Decode.list Json.Decode.string).
MikePors
commented
Oct 31, 2019
| "jsonDecPolymorphicData : Json.Decode.Decoder a -> Json.Decode.Decoder b -> Json.Decode.Decoder (PolymorphicData a b)\n"<> | ||
| "jsonDecPolymorphicData _ _ = Debug.todo \"finish\"\n\n" <> | ||
| "jsonDecSomeRecord : Json.Decode.Decoder SomeRecord\n"<> | ||
| "jsonDecSomeRecord = Debug.todo \"finish\"\n\n\n")] |
There was a problem hiding this comment.
Spoofing the parameterized decoders which would be generated by elm-bridge.
MikePors
commented
Oct 31, 2019
| , body = | ||
| Http.emptyBody | ||
| , expect = | ||
| Http.expectJson toMsg ((jsonDecPolymorphicData (Json.Decode.list (Json.Decode.string))) jsonDecSomeRecord) |
|
This is fantastic! Thank you for the well-made PR. |
|
Released as 0.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First off: I'm a huge fan of this library.
In a recent project I encountered a problem where the generated API code for an endpoint which returned an (Either [String] Identifier) was being compiled to:
, expect = jsonDec(Either (List String) Identifier)which fails to compile. This pull request changes the output in this case to:
, expect = Http.expectJson toMsg ((jsonDecEither (Json.Decode.list (Json.Decode.string))) jsonDecIdentifier)which matches with the generated decoder.
I built the repo referenced in #58 both as-is and using the changes from this repo and the compilation issue there seems to have gone away.