Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Allow warp-3.3 #156

Open
phadej opened this issue Nov 14, 2019 · 2 comments
Open

Allow warp-3.3 #156

phadej opened this issue Nov 14, 2019 · 2 comments

Comments

@phadej
Copy link
Contributor

phadej commented Nov 14, 2019

Which is e.g. in Stackage nightly.

Looks like that servant-auth-client tests timeout with it. I don't know why, all help is welcome.

@erewok
Copy link
Contributor

erewok commented Jun 21, 2020

I was experimenting with bumping the dependencies on servant and servant-auth (to run them under GHC 8.10) and I noticed this issue and tried it (on GHC 8.8.3). I did not see the problem mentioned here where tests were timing out. They all passed fine (after I increased the file descriptor limit on OSX, see #113 ). Is it possible that the file-descriptor limit problem is also the cause of the above?

For reference, here's a record of what I ran and the results (OSX 1.15.5):

~/open_source/servant-auth master*ulimit -n 2048

~/open_source/servant-auth master* 3m 15s
❯ git diff
diff --git a/servant-auth-client/servant-auth-client.cabal b/servant-auth-client/servant-auth-client.cabal
index 3e26705..352b435 100644
--- a/servant-auth-client/servant-auth-client.cabal
+++ b/servant-auth-client/servant-auth-client.cabal
@@ -73,7 +73,7 @@ test-suite spec
     , time                 >= 1.5.0.1  && < 1.10
     , transformers         >= 0.4.2.0  && < 0.6
     , wai                  >= 3.2.1.2  && < 3.3
-    , warp                 >= 3.2.25   && < 3.3
+    , warp                 >= 3.3      && < 3.4
     , jose                 >= 0.7.0.0  && < 0.9
   other-modules:
       Servant.Auth.ClientSpec

~/open_source/servant-auth master*
❯ cabal test servant-auth-client
Build profile: -w ghc-8.8.3 -O1
In order, the following will be built (use -v for more details):
 - servant-auth-client-0.4.0.0 (test:spec) (first run)
Preprocessing test suite 'spec' for servant-auth-client-0.4.0.0..
Building test suite 'spec' for servant-auth-client-0.4.0.0..

on the commandline: warning:
    -XAutoDeriveTypeable is deprecated: Typeable instances are created automatically for all types since GHC 8.2.

on the commandline: warning:
    -XAutoDeriveTypeable is deprecated: Typeable instances are created automatically for all types since GHC 8.2.
Running 1 test suites...
Test suite spec: RUNNING...
Test suite spec: PASS
Test suite logged to:
/Users/erewok/open_source/servant-auth/dist-newstyle/build/x86_64-osx/ghc-8.8.3/servant-auth-client-0.4.0.0/t/spec/test/servant-auth-client-0.4.0.0-spec.log
1 of 1 test suites (1 of 1 test cases) passed.

@domenkozar
Copy link
Collaborator

As an example you can see 9min to run tests (that should otherwise take 30s) here: https://github.com/haskell-servant/servant-auth/runs/1027581773?check_suite_focus=true

The good news is that github actions don't fail on no output, so we can allow warp-3.3 and defer this work to improve CI build times.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants