Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for acr_values configuration of oidc #275

Open
matya opened this issue Feb 2, 2024 · 0 comments
Open

Adding support for acr_values configuration of oidc #275

matya opened this issue Feb 2, 2024 · 0 comments

Comments

@matya
Copy link

matya commented Feb 2, 2024

The oidc specification details the use of ACR Values that can optionally be provided for an auth request.

This is often coupled with specifying critical requirements to the auth process, like the use of MFA.

There have been periodic questions in the community about the availability of this feature:

After reviewing the code and following up the code-path laid out by eliasp in the second discussion, it is not too complicated to enable the use of the already existing feature within the hashicorp/cap package, internally used by this plugin, it only requires handling the more or less trivial configuration field, the heavy lifting is already implemented.

I am opening this issue to propose a PR with the mentioned feature and coordinate any possible feedback / recommendation / modification requirements.

matya added a commit to matya/vault-plugin-auth-jwt that referenced this issue Feb 3, 2024
* Adding support for `acr_values` configuration of oidc endpoint

* Adding support for `acr_values` configuration of each role

Ref:
  https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant