Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: RDS Blue/Green Deployments are not tagged #35623

Open
curator opened this issue Feb 2, 2024 · 1 comment
Open

[Bug]: RDS Blue/Green Deployments are not tagged #35623

curator opened this issue Feb 2, 2024 · 1 comment
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. tags Pertains to resource tagging.

Comments

@curator
Copy link
Contributor

curator commented Feb 2, 2024

Terraform Core Version

1.7.2

AWS Provider Version

5.34.0

Affected Resource(s)

aws_db_instance

Expected Behavior

When setting blue_green_update.enabled = true the resulting deployment resource should be tagged (either by propagating instance tags or allowing a separate set to defined).

Actual Behavior

There are no tags on the deployment resource, which causes ABAC IAM policies to fail.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_db_instance" "hive-metastore" {
  apply_immediately    = var.db_apply_immediately

  identifier           = local.instance_name
  allocated_storage    = var.allocated_storage
  storage_type         = var.storage_type
  engine               = var.engine
  engine_version       = var.engine_version
  instance_class       = var.instance_class
  db_name              = var.db_name
  username             = var.master_username
  password             = var.master_password
  parameter_group_name = aws_db_parameter_group.hive-metastore-pg.name
  iops                 = var.iops

  db_subnet_group_name = aws_db_subnet_group.hive-metastore.name
  vpc_security_group_ids = [ data.aws_security_group.metadata-in-mysql-vpc.id ]
  multi_az             = "false"
  performance_insights_enabled = "true"

  backup_retention_period   = 30
  backup_window             = "06:00-07:00"
  skip_final_snapshot       = "true"
  copy_tags_to_snapshot     = "true"

  lifecycle {
    prevent_destroy = false
  }

  blue_green_update {
   enabled = true
  }

  tags = {
    Name                 = local.instance_name
    environment          = var.environment
    provisioner          = "terraform"
    git_repo             = var.git_repo
  }
}

Steps to Reproduce

Run terraform with an instance that has tags and blue_green_update { enabled = true }.

Debug Output

No response

Panic Output

No response

Important Factoids

ABAC is important in constraining blast radius, so being able to tag appropriately all the way through is important.

References

No response

Would you like to implement a fix?

None

@curator curator added the bug Addresses a defect in current functionality. label Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Feb 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 2, 2024
@justinretzolk justinretzolk added tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. tags Pertains to resource tagging.
Projects
None yet
Development

No branches or pull requests

2 participants