New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch GitHub highlighting to `hashicorp/syntax` #35

Closed

6 of 7 tasks

radeksimko opened this issue May 4, 2022 · 0 comments

Closed

6 of 7 tasks

Switch GitHub highlighting to `hashicorp/syntax` #35

radeksimko opened this issue May 4, 2022 · 0 comments

Assignees

Member

radeksimko commented May 4, 2022 •

edited by dbanck

Loading

Background

Currently GitHub uses https://github.com/alexlouden/Terraform.tmLanguage for highlighting HCL:

https://github.com/github/linguist/blob/cddf7476af4c95d1572956ffc5c0cb84f7e431c5/lib/linguist/languages.yml#L2384-L2399

That project is primarily used for highlighting in Sublime Text and has also limited maintenance capacity as per SublimeText/Terraform#36

Proposal

Variables with no space between them break syntax highlighting #34
Release v0.1 of https://marketplace.visualstudio.com/items?itemName=hashicorp.hcl
Wait for a few weeks to gather any feedback from VS Code users
Bring over syntax tests from https://github.com/alexlouden/Terraform.tmLanguage (and remember to give credit to Pat Gaffney)
Ensure the configuration under test produces comparable or better highlighting to https://github.com/alexlouden/Terraform.tmLanguage

Raise PR to github/linguist to:

switch GitHub's highlighting of HCL to hcl grammar in this repo
add GitHub's highlighting of Sentinel via grammar in this repo

The text was updated successfully, but these errors were encountered:

radeksimko changed the title ~~Switch GitHub highlighting to hashicorp/syntax~~ Switch GitHub highlighting to hashicorp/syntax

radeksimko mentioned this issue

meta: Product-agnostic HCL syntax highlighting hashicorp/vscode-terraform#638

Closed

dbanck mentioned this issue

Add support for namespaced functions to HCL grammar #110

Merged

dbanck self-assigned this

dbanck closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment