New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for type mismatch in nvml/driver_default.go #57

Merged

tgross merged 1 commit into hashicorp:main from Quiq:fix-driver-default

Dec 9, 2024

Contributor

roman-vynar commented Dec 9, 2024

Fix for type mismatch in nvml/driver_default.go:

../../go/pkg/mod/github.com/hashicorp/[email protected]/nvml/client.go:78:11: cannot use driver (variable of type *nvmlDriver) as NvmlDriver value in struct literal: *nvmlDriver does not implement NvmlDriver (wrong type for method ListDeviceUUIDs)
		have ListDeviceUUIDs() ([]string, error)
		want ListDeviceUUIDs() (map[string]mode, error)


          Fix nvml/driver_default.go

roman-vynar requested a review from a team as a code owner

December 9, 2024 09:15

tgross approved these changes

View reviewed changes

Member

tgross left a comment

LGTM. Thanks @roman-vynar !

tgross merged commit 08d1c99 into hashicorp:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet