Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra validation on Gossip and GRPC certificate input #1288

Open
jbair06 opened this issue Dec 4, 2024 · 0 comments
Open

Add extra validation on Gossip and GRPC certificate input #1288

jbair06 opened this issue Dec 4, 2024 · 0 comments
Assignees
Milestone

Comments

@jbair06
Copy link
Member

jbair06 commented Dec 4, 2024

Certificates are supposed to end in a newline. Currently, validation exists to ensure that there is a newline at the end of the text. However, an extra precaution would be to ensure that the certificate ends in a single newline, not allowing the user to enter multiple newlines at the end of the certificate.

Gossip CA Cert might already handle this by default, and if not, will likely error out. But the larger concern is the GRPC certificate. If multiple newlines occur at the end of the GRPC certificate, the hash will change, which will cause issues.

@Petyo-Lukanov Petyo-Lukanov added this to the v0.6 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants