-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnvoyProxy Auth Layer POC #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Jotted down some consideration for post POC
envoy-auth-layer/Dockerfile
Outdated
@@ -0,0 +1,17 @@ | |||
FROM envoyproxy/envoy:v1.28-latest | |||
# copy envoy.yaml to the container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove commented out code
docker run --name postgres-envoy-test -e POSTGRES_PASSWORD=mysecretpassword -p 5432:5432 -d postgres | ||
``` | ||
|
||
Run init script to create the database and the table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consideration for later, we can make the envoy proxy have read only permissions to the db or cache, while the token manager preserves the write permissions
id integer, | ||
token character varying(255) NOT NULL, | ||
method character varying(50) NOT NULL, | ||
param_name character varying(50) NOT NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
param_name
is a placeholder for subgraph name and email for later right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is more like param.name
of the json payload. but this is not final, so this could change.
… of a long term final solution. Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…s and improved a little on the docs instructions, also moved the copy of the filters from the mapping volume on the docker-compose to the Dockerfile, so those files can be copied and included with the image at build time Signed-off-by: Alfredo Gutierrez <[email protected]>
78b5e98
to
5d303d5
Compare
Description:
This is a good start for the implementation of
EnvoyProxy
as a reverse proxy forHedera-The-Graph
Auth layer.Related issue(s):
#18
Fixes #24
Notes for reviewer:
Next tasks:
EnvoyProxy
.(I would say Yes)
redis
vspostgres
for the token db store.(I would say postgres)
hedera-the-graph-auth-layer
hedera-the-graph
.Checklist