Implemented the logic to support Nonce Filter on /api/v1/transactions/{hash} #9842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Sawarkar <[email protected]>
…into chore-Nonce-Filter-Is-Ignored-on-API-call-with-transactionHash
jnels124
reviewed
Dec 4, 2024
…into chore-Nonce-Filter-Is-Ignored-on-API-call-with-transactionHash
Signed-off-by: Harsh Sawarkar <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
…into chore-Nonce-Filter-Is-Ignored-on-API-call-with-transactionHash
Signed-off-by: Harsh Sawarkar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9842 +/- ##
============================================
- Coverage 92.25% 92.25% -0.01%
Complexity 7821 7821
============================================
Files 953 953
Lines 32731 32731
Branches 4146 4146
============================================
- Hits 30197 30196 -1
Misses 1559 1559
- Partials 975 976 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the logic to filter based out of nonce.
Related issue(s):
Fixes #9715
Notes for reviewer:
Check for
if(isTransactionHash)inextractSqlFromTransactionsByIdOrHashRequestintransactions.jsChecklist