Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Spotless in CI #9023

Closed
steven-sheehy opened this issue Aug 14, 2024 · 0 comments · Fixed by #9866
Closed

Verify Spotless in CI #9023

steven-sheehy opened this issue Aug 14, 2024 · 0 comments · Fixed by #9866
Assignees
Labels
enhancement Type: New feature github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Milestone

Comments

@steven-sheehy
Copy link
Member

steven-sheehy commented Aug 14, 2024

Problem

Sometimes spotless doesn't run on a PR before it's merged to main despite it being configured to run automatically as part of a git hook. This can cause other's PRs that merge from main afterwards to automatically run spotless against files they didn't change.

Solution

Add a check in security CI that runs spotlessCheck and fails the check if any files need to be changed by Spotless

Alternatives

No response

@steven-sheehy steven-sheehy added enhancement Type: New feature github_actions Pull requests that update GitHub Actions code labels Aug 14, 2024
@steven-sheehy steven-sheehy moved this to 🏃‍♀ Sprint backlog in Mirror Node Aug 14, 2024
@steven-sheehy steven-sheehy changed the title Verify Spotless ran in CI Verify Spotless ran CI Aug 15, 2024
@steven-sheehy steven-sheehy changed the title Verify Spotless ran CI Verify Spotless in CI Aug 15, 2024
@steven-sheehy steven-sheehy added this to the 0.113.0 milestone Aug 19, 2024
@steven-sheehy steven-sheehy removed this from the 0.113.0 milestone Sep 2, 2024
@steven-sheehy steven-sheehy moved this from 🏃‍♀ Sprint backlog to 📋 Backlog in Mirror Node Oct 13, 2024
@steven-sheehy steven-sheehy added the good first issue Good for newcomers label Nov 26, 2024
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 👷 In progress in Mirror Node Nov 26, 2024
@sdimitrov9 sdimitrov9 linked a pull request Nov 27, 2024 that will close this issue
2 tasks
@steven-sheehy steven-sheehy added this to the 0.120.0 milestone Dec 2, 2024
@steven-sheehy steven-sheehy moved this from 👷 In progress to 👀 In review in Mirror Node Dec 2, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Mirror Node Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
Status: Done
2 participants