identify community nodes in address book

[kimbor]

Add a flag to the address book to indicate whether a node belongs to a council member or a community member. Update related protobuf message and mirror node response objects.

#690

[steven-sheehy]

The nodeAddress link is broken.

[kimbor]

Thanks. I opened a PR to fix it. #697

[kimbor]

That PR has been merged.

[steven-sheehy]

We should use an enum value instead of a boolean communityNode flag to allow future expansion. Something like:

enum NodeType {
  COUNCIL = 0;
  PERMISSIONED = 1;
  PERMISSIONLESS = 2;
}

[kimbor]

Working on it. I'll have a PR up shortly.

[kimbor]

#699

[steven-sheehy]

Please add the raw protobuf changes to the HIP. This should include proto comments that note that default value. Please also show the field being added to the output of the /api/v1/network/nodes JSON in an example.

[kimbor]

This PR adds the raw protobuf:
#699

[steven-sheehy]

Node addresses are configured in a JSON-formatted network file defined by the NodeAddressBook protobuf.

This is not really true. There is a separate JSON formatted address book used internally by the platform layer. The proto NodeAddressBook is separate and not used by the platform. I'm not sure if yahcli takes in JSON to update the NodeAddressBook, but that's irrelevant and we should just remove the JSON comment to reduce confusion.

[kimbor]

Thanks. I deleted that sentence in PR 699.

[mthometech]

Is there something different or lesser about community nodes vs council nodes? If they are the same, I would instead suggest a memo or alias field that allows any node to associate the name of the organization or individual operating the node. This would also accommodate for the future when anyone can run a node.