Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hardhat] Workaround for eth_getCode when token was not yet created #91

Closed
acuarica opened this issue Oct 30, 2024 · 0 comments · Fixed by #92
Closed

[Hardhat] Workaround for eth_getCode when token was not yet created #91

acuarica opened this issue Oct 30, 2024 · 0 comments · Fixed by #92
Assignees
@acuarica
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@acuarica
Copy link
Contributor

From hashgraph/hedera-json-rpc-relay#3155

The JSON-RPC method eth_getCode does not take into account the blockNumber when the address corresponds to an HTS token. It always returns the redirect bytecode, specified by HIP-719, regardless of the provided blockNumber.

Implement a workaround for this issue in the Hardhat plugin, so we don't depend on issue hashgraph/hedera-json-rpc-relay#3155 getting fixed.

Note

This workaround is only valid for the Hardhat plugin. Given how the Foundry library works, we don't have a hook to detect when an eth_getCode call is invoked.
@acuarica acuarica self-assigned this Oct 30, 2024
@acuarica acuarica added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Oct 30, 2024
@acuarica acuarica moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Oct 30, 2024
@acuarica acuarica mentioned this issue Oct 30, 2024
Merged
2 tasks
@acuarica acuarica linked a pull request Oct 30, 2024 that will close this issue
fix: workaround for eth_getCode when token was not yet created #92
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Tasks In Progress to Done in Smart Contract Sprint Board Oct 31, 2024
@acuarica acuarica changed the title Workaround for eth_getCode when token was not yet created [Hardhat] Workaround for eth_getCode when token was not yet created Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acuarica acuarica

Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Smart Contract Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: workaround for eth_getCode when token was not yet created hashgraph/hedera-forking
1 participant
@acuarica