Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-dimensional input? #13

Closed
sprungj opened this issue Dec 13, 2023 · 3 comments
Closed

N-dimensional input? #13

sprungj opened this issue Dec 13, 2023 · 3 comments

Comments

@sprungj
Copy link

sprungj commented Dec 13, 2023

Readme says input array can be D-dimensional points, but AlphaShape function seems to enforce 2 dimensions:

X::AbstractArray{Float64,2}

Unless I am misreading?

@harveydevereux
Copy link
Owner

Apologies for the delay @sprungj

Yes the readme is wrong here - points in main must be 2 dimensional.

In principal 3D + should work if the functions are updated if I recall correctly, in fact 3D was working in the dev branch https://github.com/harveydevereux/AlphaShapes.jl/tree/dev

I need to merge some optimisations that change the API as well into a new release.

I shall address this soon, along with that, and perhaps include 3d and see if Nd will work.

@harveydevereux
Copy link
Owner

@sprungj thanks for flagging, readme is updated. Will also see if N-D can be achieved for a 0.4.0 release, should be as MiniQhull.jl does

@sprungj
Copy link
Author

sprungj commented Dec 18, 2023

Thanks for the update -- looking forward to 0.4.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants