Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching when non interpolating Masters are on the file (Sans / Serif) #11

Open
franciscotorress opened this issue Jan 31, 2022 · 4 comments

Comments

@franciscotorress
Copy link

franciscotorress commented Jan 31, 2022

Hi,

I have a file with 2 serif & 2 sans masters but there is no interpolation between Sans & Serif. However plugin shows me bad (yellow) values when in fact they are ok.

Screenshot 2022-01-31 at 17 11 23

Is there any way of avoid this? Any axes setup for example?
I tried different designspace/masters setup & to use the parameter "Disable Masters" on certain instances but both didn't work.

@franciscotorress franciscotorress changed the title Matching between Masters (Sans / Serif) Matching between non interpolating Masters (Sans / Serif) Jan 31, 2022
@franciscotorress franciscotorress changed the title Matching between non interpolating Masters (Sans / Serif) Matching when non interpolating Masters are on the file (Sans / Serif) Jan 31, 2022
@harbortype
Copy link
Owner

Hi Francisco! Apologies for the late reply.

No, there is no way to turn this off yet. I could take a look at it, but I’m not sure what’s the best approach here. I think I could make the plugin look for a font-wide custom parameter in which you tell it which axes should not be checked for kinks. Any opinion on this?

By the way, you say there is no interpolation between Sans and Serif, but is this going to be an axis on a variable font? If that’s the case, just thought to mention that the highlighted nodes could produce kinks along this Sans/Serif axis.

@franciscotorress
Copy link
Author

It's ok Henrique. No rush!

Yes it would be nice if we could decide directly on the plugin what masters should be checked or not.

No, no Sans to Serif axes in this case. We just have them on the same file because they share a lot of information so it was easier to develop to project.

I know it's rare, but I think there are a few more cases where it could be nice to decide if we want to check the kink or not: Very big family (xxx wide to xxx condensed), Roman and Italic on the same file, etc

Let me know if you need more help with this.
Thanks

@harbortype
Copy link
Owner

No, no Sans to Serif axes in this case. We just have them on the same file because they share a lot of information so it was easier to develop to project.

I think I understand it. Just to be sure, can you share a stripped down version of the file with me? I’d like to take a look at how the masters and instances are set up and the paths of a single glyph (you can delete all the other glyphs). If you can’t share it here, you may send it to me at [email protected].

I know it's rare, but I think there are a few more cases where it could be nice to decide if we want to check the kink or not: Very big family (xxx wide to xxx condensed), Roman and Italic on the same file, etc

Absolutelly. I personally don’t work with romans and italics on the same file, but I get that some people do. I just disagree that it shouldn’t check wides against condenseds because this would probably become a variable font and kinks might happen along that width axis (just wanted to mention this in case someone reads this in the future).

@franciscotorress
Copy link
Author

Here it is:
STR_Smooth.glyphs.zip

In this case I built it with weight and optical size to separate interpolations. But in a first try I placed the four masters in the weight axes with 0-100 for Sans & 200-300 for Serif (for example) and then the instances on 150 for Sans and 250 for serif of course.

In both designspaces, I was expecting the plugin to read the instances then give the possible kink color or not.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants